Skip to main content

chained-rule-body

Summary: Avoid chaining rule bodies

Category: Style

Avoid

package policy

has_x_or_y {
    input.x
} {
    input.y
}

Prefer

package policy

has_x_or_y {
    input.x
}

has_x_or_y {
    input.y
}

Rationale​

If the head of the rule is same, it's possible to chain multiple rule bodies together to obtain the same result. This form was more common in the past, but is no longer recommended as it is arguably less readable, and less likely to be understood by people new to Rego.

Exceptions​

The opa fmt command will automatically "unchain" chained rule bodies, so if you have enabled the opa-fmt rule, you may safely configure the level of this rule to ignore. While we normally don't include style rules covered by opa fmt, this one is peculiar enough that we felt it was worthy of an exception.

Configuration Options​

This linter rule provides the following configuration options:

rules:
  style:
    chained-rule-body:
      # one of "error", "warning", "ignore"
      level: error