Skip to main content

single-item-in

Summary: Avoid in for single item collection

Category: Idiomatic

Avoid

package policy

allow if input.role in {"admin"}

Prefer

package policy

allow if input.role == "admin"

Rationale​

Using in on a single-item collection (array, set or object) is a convoluted way of checking for equality. Better then to check for equality directly! Besides being more obvious, equality checks are also subject to rule indexing, whereas in checks currently aren't.

Configuration Options​

This linter rule provides the following configuration options:

rules:
  idiomatic:
    single-item-in:
      # one of "error", "warning", "ignore"
      level: error